feat: miner: --peer-id-keyfile flag for lotus-miner init #11474
+59
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
This PR introduces the
--peer-id-keyfile
option to miner initialization, allowing users to import pre-existing or deterministic libp2p peer IDs. This feature is particularly useful in integration tests where consistent peer IDs are required.By enabling the import of specific peer IDs, we streamline testing processes and enhance the predictability of test outcomes.
Additional Info
sample
lib2p-12D3KooWQooJ1ytSud5qTJSeG49kx5o38k1PbZHs4kMfP4QVXq1R.key
It can be inspected for debugging puproses like this:
In the end it should match with the private key generated in the
~/.miner/keystore/NRUWE4BSOAWWQ33TOQ
file:Affected log output lines on miner init by this change look like this:
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps