Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lotus-provider: Serialization fix #11501

Merged
merged 5 commits into from
Dec 11, 2023
Merged

fix: lotus-provider: Serialization fix #11501

merged 5 commits into from
Dec 11, 2023

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Dec 7, 2023

Related Issues

Proposed Changes

  1. Retry txns that have a serialization error. It's recoverable.
  2. Disallow incorrectly coded Transactional code by detecting it at runtime.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@@ -102,6 +103,9 @@ var wdPostTaskCmd = &cli.Command{
return true, nil
})
if err != nil {
if harmonydb.IsErrSerialization(err) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we be indefinitely looping here, or there should be a max retry?

@rjan90 rjan90 changed the title Serialization fix fix: lotus-provider: Serialization fix Dec 11, 2023
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transaction retry / changes in db_index look good; Some comments around usedInTransaction

lib/harmony/harmonydb/userfuncs.go Show resolved Hide resolved
lib/harmony/harmonydb/userfuncs.go Outdated Show resolved Hide resolved
lib/harmony/harmonydb/harmonydb.go Outdated Show resolved Hide resolved
@snadrus snadrus merged commit c912f3b into master Dec 11, 2023
88 of 89 checks passed
@snadrus snadrus deleted the serializationFix branch December 11, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants