Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Curio - Easy Migration #11617

Merged
merged 51 commits into from
Mar 15, 2024
Merged

feat: Curio - Easy Migration #11617

merged 51 commits into from
Mar 15, 2024

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Feb 12, 2024 •
edited
Loading

Related Issues

This is a guided migration from lotus-miner to curio that's also in Korean and Mandarin.
Also included is the lotus-provider to curio complete rename (including internals). Not renamed: harmony.

BREAKING CHANGE for alpha users: db schema "lotus" became "curio".
No migration provided. Tables must be renamed for alpha users.

It depends on:

  • Multi-miner wallet
  • lotus-miner as a sector uploader when config and db set up.
  • (external repo) value recording for usage stats.

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@snadrus snadrus requested a review from magik6k February 12, 2024 23:56
LexLuthr
LexLuthr reviewed Feb 19, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good. I just found some minor issues. Once the first draft is complete, we can improve further by running this in devnet. I have also asked a Korean SP engineer to verify the Korean translation to cover all bases.

cmd/lotus-provider/deps/deps.go Outdated Show resolved Hide resolved
cmd/lotus-provider/deps/deps.go Outdated Show resolved Hide resolved
cmd/lotus-provider/guidedSetup/guidedSetup.go Outdated Show resolved Hide resolved
cmd/lotus-provider/guidedSetup/guidedSetup.go Outdated Show resolved Hide resolved
cmd/lotus-provider/guidedSetup/guidedSetup.go Outdated Show resolved Hide resolved
cmd/lotus-provider/guidedSetup/guidedSetup.go Outdated Show resolved Hide resolved
cmd/lotus-provider/guidedSetup/guidedSetup.go Outdated Show resolved Hide resolved
snadrus and others added 8 commits February 19, 2024 22:49
@snadrus snadrus marked this pull request as ready for review March 2, 2024 01:18
@snadrus snadrus requested a review from a team as a code owner March 2, 2024 01:18
@snadrus
Copy link
Collaborator Author

snadrus commented Mar 2, 2024

Please test in another miner before committing to main.

@snadrus snadrus changed the title feat: lp mig - first few steps feat: Curio - Easy Migration Mar 4, 2024
@snadrus
Copy link
Collaborator Author

snadrus commented Mar 12, 2024

@magik6k ready for review.
Status: Works for me to take a by-the-book dev-net to Curio in one shot with no prior knowledge.

magik6k
magik6k reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review so far, didn't go deep into the guided setup yet

cli/util/api.go Outdated Show resolved Hide resolved
cmd/curio/deps/deps.go Outdated Show resolved Hide resolved
cmd/curio/stop.go Outdated Show resolved Hide resolved
lib/harmony/harmonydb/sql/20240212-common-layers.sql Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
magik6k
magik6k reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, some small bugs, and generally looks a bit hairy, but that is to be expected of UI code

cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
cmd/curio/guidedsetup/guidedsetup.go Show resolved Hide resolved
node/config/load.go Outdated Show resolved Hide resolved
localnet.json Outdated Show resolved Hide resolved
magik6k
magik6k approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good now, just some nits + needs a green CI + conflict resolving

I presume that the "start fresh cluster" path will come later, along with handling of all the random edge cases we discover here

devgen.car Outdated Show resolved Hide resolved
lib/harmony/harmonydb/sql/20240212-common-layers.sql Outdated Show resolved Hide resolved
LexLuthr
LexLuthr reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to successfully migrate with one change.

cmd/curio/guidedsetup/guidedsetup.go Outdated Show resolved Hide resolved
@masih masih removed their request for review March 15, 2024 13:28
@snadrus snadrus merged commit 81ba6ab into master Mar 15, 2024
89 of 90 checks passed
@snadrus snadrus deleted the easyMigration branch March 15, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennijuju jennijuju jennijuju left review comments

@magik6k magik6k magik6k approved these changes

@LexLuthr LexLuthr LexLuthr approved these changes

@aarshkshah1992 aarshkshah1992 Awaiting requested review from aarshkshah1992 aarshkshah1992 was automatically assigned from filecoin-project/lotus-maintainers

@Stebalien Stebalien Awaiting requested review from Stebalien

@ZenGround0 ZenGround0 Awaiting requested review from ZenGround0

@arajasek arajasek Awaiting requested review from arajasek

@rjan90 rjan90 Awaiting requested review from rjan90

@rvagg rvagg Awaiting requested review from rvagg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snadrus @magik6k @jennijuju @LexLuthr