feat: events: Add Lotus APIs to consume smart contract and built-in actor events #11618
Commits on Mar 5, 2024
-
-
-
-
-
-
-
-
-
-
-
-
-
More post-review changes, lots of tests for SubscribeActorEvents
Use BlockDelay as the window for receiving events on the SubscribeActorEvents channel. We expect the user to have received the initial batch of historical events (if any) in one block's time. For real-time events we expect them to not fall behind by roughly one block's time.
-
Remove duplicate code from actor event type marshalling tests
Reduce verbosity and remove duplicate test logic from actor event types JSON marshalling tests.
-
Rename actor events test to follow go convention
Add missing `s` to `actor_events` test file to follow golang convention used across the repo.
-
Run actor events table tests in deterministic order
Refactor `map` usage for actor event table tests to ensure deterministic test execution order, making debugging potential issues easier. If non-determinism is a target, leverage Go's built-in parallel testing capabilities.
-
Reduce scope for filter removal failure when getting actor events
Use a fresh context to remove the temporary filter installed solely to get the actor events. This should reduce chances of failure in a case where the original context may be expired/cancelled. Refactor removal into a `defer` statement for a more readable, concise return statement.
-
Use fixed RNG seed for actor event tests
Improve determinism in actor event tests by using a fixed RNG seed. This makes up a more reproducible test suit.
-
Use provided libraries to assert eventual conditions
Use the functionalities already provided by `testify` to assert eventual conditions, and remove the use of `time.Sleep`. Remove duplicate code in utility functions that are already defined. Refactor assertion helper functions to use consistent terminology: "require" implies fatal error, whereas "assert" implies error where the test may proceed executing.
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.