Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal events modules for clarity #11626

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 19, 2024

Based on feedback @ #11618 (comment) I thought that it worth doing some naming clarification. The other change I want to make but it would make for a noisy diff, is to move the EthEventHandler out of eth.go and into eth_events.go but that's not a big deal.

The clarity mostly shows up in node/builder_chain.go when it all comes together.

@rvagg
Copy link
Member Author

rvagg commented Feb 19, 2024

(This is a PR against #11618 btw)

@rvagg rvagg merged commit 8704b16 into rvagg/feat/builtin-actor-events Feb 21, 2024
89 of 90 checks passed
@rvagg rvagg deleted the rvagg/event-module-naming branch February 21, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

1 participant