Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CLI: add expiration to claim list #11671

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Mar 4, 2024

Related Issues

Fixes #11669

Proposed Changes

Addition column called "Expiration" equivalent to Claim.TermMax + claim.TermStart

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@LexLuthr LexLuthr requested a review from a team as a code owner March 4, 2024 08:47
cli/filplus.go Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Mar 4, 2024

@nezha90 care to add a +1?

@Stebalien Stebalien merged commit e84a61c into master Mar 4, 2024
88 checks passed
@Stebalien Stebalien deleted the feat/cli-claim-expiration branch March 4, 2024 21:09
@Stebalien
Copy link
Member

Looks correct so I'm going to merge. But an additional +1 from @nezha90 would still be nice.

@nezha90
Copy link

nezha90 commented Mar 11, 2024

+1 means? @rvagg

@rvagg
Copy link
Member

rvagg commented Mar 11, 2024

@nezha90 we just wanted you to eye this and give a tick of approval, since you were the original reporter

@nezha90
Copy link

nezha90 commented Mar 11, 2024

😂thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

command:lotus filplus list-claims, expiration time
5 participants