-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CLI: add claim-extend cli #11711
Conversation
maybe hold off until we make it work: filecoin-project/go-state-types#254 |
merged types changes in filecoin-project/go-state-types#254, @rjan90 I think probably a new rc from go-state-types that we can pull in to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice, if it works as advertised. I like that it's asking for confirmation when needing to spend datacap.
Did you have a draft itest somewhere for this when you found that encoding discrepancy originally on ClaimExtensionRequest
? I know this is really hard to test, but perhaps there's something minimal we could do at least?
I was testing e2e in devnet but an itest sounds good. I can create one which quickly creates a claim and then extends it. |
Hello, I took the time to look at it today. I found that there is no This message is the same as the renewal sector. When the number is large, a large amount of gas will be used, exceeding the block limit, so an error will be reported when renewing a large number of deals. So please confirm whether there is batching logic. If not, you may need to add it. ps: When I was renewing the deal, I found that it was already |
* add claim-extend cli * fix arg usage * add missing question * fix client addr, datacap prompt * replace waitGrp with errGrp * use promptUI * replace fmt.ErrorF with xerror * apply var name suggestion * GST rc3, update types * add itest * make gen * add changelog
* add claim-extend cli * fix arg usage * add missing question * fix client addr, datacap prompt * replace waitGrp with errGrp * use promptUI * replace fmt.ErrorF with xerror * apply var name suggestion * GST rc3, update types * add itest * make gen * add changelog
* add claim-extend cli * fix arg usage * add missing question * fix client addr, datacap prompt * replace waitGrp with errGrp * use promptUI * replace fmt.ErrorF with xerror * apply var name suggestion * GST rc3, update types * add itest * make gen * add changelog
* add claim-extend cli * fix arg usage * add missing question * fix client addr, datacap prompt * replace waitGrp with errGrp * use promptUI * replace fmt.ErrorF with xerror * apply var name suggestion * GST rc3, update types * add itest * make gen
* add claim-extend cli * fix arg usage * add missing question * fix client addr, datacap prompt * replace waitGrp with errGrp * use promptUI * replace fmt.ErrorF with xerror * apply var name suggestion * GST rc3, update types * add itest * make gen
Related Issues
Fixes #10001
Proposed Changes
The new command creates extend message[s] based on the following conditions
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps