Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: curio: web based config edit #11822

Merged
merged 63 commits into from
Apr 16, 2024
Merged

feat: curio: web based config edit #11822

merged 63 commits into from
Apr 16, 2024

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Apr 4, 2024 •
edited
Loading

Related Issues

  1. guided-setup for migrations sometimes does not bring over the API key
  2. WARN if no POST worker is present for the miner IDs we are servicing.
  3. Fix docs generation for curio-cli.
  4. Config Editor
    image
    Screenshot 2024-04-05 at 10 54 20 PM

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

snadrus and others added 30 commits January 30, 2024 16:25
@snadrus
cfg edit 1
d36245c
@snadrus
jsonschema deps
fb86554
@snadrus
feat: lp mig - first few steps
f6f4d0e
@snadrus
lp mig: default tasks
229645b
@snadrus
code comments
5a61b87
@snadrus
docs
17ffd12
@snadrus
lp-mig-progress
0c8969d
@snadrus
Merge branch 'master' into easyMigration
aa049ba
@snadrus
shared
6765ac1
@snadrus
comments and todos
d47b2f7
@LexLuthr
fix: curio: rename lotus-provider to curio (#11645)
443b05c 
* rename provider to curio

* install gotext

* fix lint errors, mod tidy

* fix typo

* fix API_INFO and add gotext to circleCI

* add back gotext

* add gotext after remerge
@snadrus
lp: channels doc
b686823
@snadrus
Merge branch 'easyMigration' of https://github.com/filecoin-project/l…
86f8624 
…otus into easyMigration
@snadrus
finish easy-migration TODOs
5c2a86b
@snadrus
out generate
345dd9c
@snadrus
Merge branch 'master' into easyMigration
94e2a37
@snadrus
merging and more renames
ef9e3f2
@snadrus
avoid make-all
af19d34
@snadrus
minor doc stuff
590537e
@snadrus
cu: make gen
3ff1e4d
@snadrus
make gen fix
ea1dd33
@snadrus
conflict-resolve
0c3d0ce
@snadrus
Merge branch 'master' into easyMigration
dedad07
@snadrus
make gen
5470aec
@snadrus
tryfix
6505b90
@snadrus
go mod tidy
9fa63fb
@snadrus
minor ez migration fixes
4c7130e
@snadrus
ez setup - ui cleanups
5086714
@snadrus
better error message
11f21a0
@snadrus
guided setup colors
9d4ed63
@snadrus snadrus marked this pull request as ready for review April 6, 2024 03:53
@LexLuthr LexLuthr changed the title Feat/config edit feat: curio: web based config edit Apr 9, 2024
magik6k
magik6k reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much to be nitpicky about, looks good if it works

curiosrc/web/static/ux/curio-ux.mod.js Outdated Show resolved Hide resolved
@snadrus snadrus requested a review from magik6k April 12, 2024 02:37
LexLuthr
LexLuthr approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to 🚢

@snadrus snadrus merged commit fd7f1a9 into master Apr 16, 2024
186 checks passed
@snadrus snadrus deleted the feat/config-edit branch April 16, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LexLuthr LexLuthr LexLuthr approved these changes

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snadrus @magik6k @LexLuthr