-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: curio: sectors UI #11869
feat: curio: sectors UI #11869
Conversation
* rename provider to curio * install gotext * fix lint errors, mod tidy * fix typo * fix API_INFO and add gotext to circleCI * add back gotext * add gotext after remerge
…otus into easyMigration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a few changes
- We should convert sealed column to PresentOnDisk
- Move unsealed next to sealed column
- We don't need Fil/Day as the number would be really low to have any useful impact
- Seal Proof is not required.
I could not find where we are getting the Size as type Sector{} doesn't seems to have one.
We also need to add another column to UI for "Proving" on chain. A sector can be on-chain but not proving. |
I'd like to stick with the has-sealed and has-unsealed language as soon having one will mean that we can (automatically?) generate the other. I want these to seem like 2 sides of the same coin (or a kind of backup) rather than two totally different concepts.
If the language was totally different between the two, then it would make things more confusing. |
The naming convention sounds good based on your explanation. |
1588309
to
f8c6252
Compare
@magik6k Can you test the rendering on your miner? We don't have any good test setup with a lot of sectors. |
@snadrus Testing results:
|
|
@snadrus We need a way to remove sectors safely. I will create a new issue for it.
|
Related Issues
Resolves an item for the Curio beta epic.
Along with 'view', it offers 'terminate'.
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps