Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: curioweb: Improve UX, add top menu #11901

Merged
merged 80 commits into from
Apr 19, 2024
Merged

feat: curioweb: Improve UX, add top menu #11901

merged 80 commits into from
Apr 19, 2024

Conversation

snadrus
Copy link
Collaborator

@snadrus snadrus commented Apr 18, 2024

Related Issues

A Unified menu and some style improvements / consistency.

Images:
Main Dash:
image

Edit Configuration, Picker:
Screenshot 2024-04-18 at 6 02 52 PM

Edit Configuration, Editor:
Screenshot 2024-04-18 at 6 11 20 PM

Sectors Page:
Screenshot 2024-04-18 at 6 13 47 PM

PoRep:
image

Documentation page not shown as it links to the known docs.

Proposed Changes

Removed Clarity (VMWare CSS Layer) except from the Config Picker page.
Built a unified style like Clarity (font, size, colors)
Hide the page until it's mostly styled (though maybe not loaded).
Bootstrap 5 (the only one that's module-capable), mostly requesting dark components.

Additional Info

The super-small screen makes a hamburger menu that doesn't work. I doubt this is a real problem, but it's ugly.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tables could use some restyling to match clarity, or at least the background color + there seem to be some regressions on the sector table pages that should get fixed, but other than that I like where this is going.

(I'll try to start some light refactor to Lit + Jsonrpc to start the train of putting all the ui code within one framework.)

2024-04-19-095711_3827x1862_scrot

curiosrc/web/hapi/simpleinfo.go Outdated Show resolved Hide resolved
curiosrc/web/srv.go Outdated Show resolved Hide resolved
curiosrc/web/static/index.html Outdated Show resolved Hide resolved
curiosrc/web/static/pipeline_porep.html Show resolved Hide resolved
curiosrc/web/static/chain-connectivity.mjs Show resolved Hide resolved
@LexLuthr
Copy link
Contributor

Apart from what Magik pointed out:

  1. Add a grid to main page
  2. Docs should open in a new tab
  3. We should filter out completed task list for winpost tasks. They clog the display and prevent users to see useful info.

@magik6k
Copy link
Contributor

magik6k commented Apr 19, 2024

(Force-push undoing commits from #11904 which I've accidentally pushed here)

@LexLuthr
Copy link
Contributor

I have pushed a commit with following changes.

  1. Fix the pipeline page
Screenshot 2024-04-19 at 4 21 04 PM
  1. Adjust config page to look better aligned
  2. All the changes Magik suggested except the Bootstrap part.

@magik6k magik6k changed the title Feat/UI menu feat: curioweb: Improve UX, add top menu Apr 19, 2024
@magik6k magik6k enabled auto-merge (squash) April 19, 2024 14:04
@magik6k magik6k merged commit 1a789d3 into master Apr 19, 2024
186 checks passed
@magik6k magik6k deleted the feat/ui-menu branch April 19, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants