feat(eth): fix EthGetTransactionCount for pending block parameter

[virajbhartiya]

Related Issues

Fixes #10357

Proposed Changes

1. Added a condition to check for the "pending" block parameter.
2. Implemented mempool nonce retrieval for "pending" blocks.
3. Included error handling for the mempool query.
4. Ensured the mempool is only accessed when necessary (i.e., for "pending" blocks).

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title conforms with contribution conventions
• Update CHANGELOG.md or signal that this change does not need it per contribution conventions
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[virajbhartiya]

@aarshkshah1992 I have added tests in fevm_tests.go. EthGetTransactionCount seemed to be tested also in TestGetCodeAndNonce but I have written a standalone test for it. Referenced the following for implementing it

lotus/itests/eth_bytecode_test.go

Lines 22 to 95 in 3a90ce4

	func TestGetCodeAndNonce(t *testing.T) {
	kit.QuietMiningLogs()
	blockTime := 100 * time.Millisecond
	client, _, ens := kit.EnsembleMinimal(t, kit.MockProofs(), kit.ThroughRPC())
	ens.InterconnectAll().BeginMining(blockTime)
	ctx, cancel := context.WithTimeout(context.Background(), time.Minute)
	defer cancel()
	// Accounts should have empty code, empty nonce.
	{
	// A random eth address should have no code.
	_, ethAddr, filAddr := client.EVM().NewAccount()
	bytecode, err := client.EVM().EthGetCode(ctx, ethAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Empty(t, bytecode)
	// Nonce should also be zero
	nonce, err := client.EVM().EthGetTransactionCount(ctx, ethAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Zero(t, nonce)
	// send some funds to the account.
	kit.SendFunds(ctx, t, client, filAddr, types.FromFil(10))
	// The code should still be empty, target is now a placeholder.
	bytecode, err = client.EVM().EthGetCode(ctx, ethAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Empty(t, bytecode)
	// Nonce should still be zero.
	nonce, err = client.EVM().EthGetTransactionCount(ctx, ethAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Zero(t, nonce)
	}
	// Check contract code.
	{
	// install a contract
	contractHex, err := os.ReadFile("./contracts/SelfDestruct.hex")
	require.NoError(t, err)
	contract, err := hex.DecodeString(string(contractHex))
	require.NoError(t, err)
	createReturn := client.EVM().DeployContract(ctx, client.DefaultKey.Address, contract)
	contractAddr := createReturn.EthAddress
	contractFilAddr := *createReturn.RobustAddress
	// The newly deployed contract should not be empty.
	bytecode, err := client.EVM().EthGetCode(ctx, contractAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.NotEmpty(t, bytecode)
	// Nonce should be one.
	nonce, err := client.EVM().EthGetTransactionCount(ctx, contractAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Equal(t, ethtypes.EthUint64(1), nonce)
	// Destroy it.
	_, _, err = client.EVM().InvokeContractByFuncName(ctx, client.DefaultKey.Address, contractFilAddr, "destroy()", nil)
	require.NoError(t, err)
	// The code should be empty again.
	bytecode, err = client.EVM().EthGetCode(ctx, contractAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Empty(t, bytecode)
	// Nonce should go back to zero
	nonce, err = client.EVM().EthGetTransactionCount(ctx, contractAddr, ethtypes.NewEthBlockNumberOrHashFromPredefined("latest"))
	require.NoError(t, err)
	require.Zero(t, nonce)
	}
	}

[aarshkshah1992]

good stuff !

[aarshkshah1992]

@rvagg Happy for me to merge this ?

[virajbhartiya]

I am unable to understand why TestGatewayRateLimits failed, it's passing when I run it locally

[rvagg]

The gateway test is on me, unfortunately: #12001 (comment)

Most of the flakies are catalogued in #12001 if you want to look them up. There are a few more not documented in there too: https://github.com/filecoin-project/lotus/issues?q=is%3Aissue+is%3Aopen+flaky

So you can ignore that one.

[rvagg]

🥳 thanks @virajbhartiya !