Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(f3): display the initial power table CID in the F3 manifest #12626

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Oct 22, 2024

Related Issues

This will make it easier to tell users how to set/verify F3_INITIAL_POWERTABLE_CID.

Proposed Changes

Display the initial power table CID in the lotus f3 manifest command output, and make sure it's set if available.

Checklist

Before you mark the PR ready for review, please make sure that:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stebalien Stebalien force-pushed the steb/initial-power-table-cmd branch from 2571da4 to fd27c51 Compare October 22, 2024 15:54
@Stebalien Stebalien changed the title Display the initial power table CID in the F3 manifest feat(f3): display the initial power table CID in the F3 manifest Oct 22, 2024
Also, add it to the manifest if not already set.
@Stebalien Stebalien force-pushed the steb/initial-power-table-cmd branch from fd27c51 to e93efc5 Compare October 22, 2024 15:55
@github-actions github-actions bot dismissed their stale review October 22, 2024 15:55

PR title now matches the required format.

@Stebalien Stebalien added the skip/changelog This change does not require CHANGELOG.md update label Oct 22, 2024
@Stebalien Stebalien requested a review from masih October 22, 2024 15:59
@Stebalien
Copy link
Member Author

@masih how have you been testing this? SSH into archioz?

chain/lf3/f3.go Show resolved Hide resolved
@masih
Copy link
Member

masih commented Oct 22, 2024

how have you been testing this? SSH into archioz?

this as in the CLI output?

@Stebalien
Copy link
Member Author

this as in the CLI output?

I'm modifying the lotus f3 manifest command.

@Stebalien
Copy link
Member Author

Yes, this as in the CLI output.

@masih
Copy link
Member

masih commented Oct 22, 2024

I have been using mock data locally. In terms of live nodes, you can use butterflynet?

@Stebalien Stebalien merged commit bc8c29b into master Oct 22, 2024
96 of 98 checks passed
@Stebalien Stebalien deleted the steb/initial-power-table-cmd branch October 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants