-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return an error for null rounds from RPC methods #12655
Conversation
I have referenced the following for injecting null rounds in the itests, lotus/itests/eth_transactions_test.go Lines 432 to 454 in cfde1d5
getTipsetByBlockNumber is always resulting in requested a future epoch (beyond 'latest') and not returning the ErrNullRound error.
|
@rvagg the |
…upport 'trace' traceTypes
…ull rounds in RPC method calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 great work
Related Issues
Fixes #12633
Checklist
Before you mark the PR ready for review, please make sure that: