Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with payment channels #1306

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Conversation

hannahhoward
Copy link
Contributor

Goals

Retrieval market is failing due to issues creating payment channels with specs-actors. This solves several of those issues -- it can now create the channel -- but it there is still a seperate issue creating vouchers.

Implementation

  1. First issue is serializing constructor params for PaymentChannel -- was missing the From field
  2. Second issue is that the storage miner actor address was being passed in the call to create payment channel -- which then fails in the paych actor. The reason is cause right now we had not been translating from the storage miner actor address to the actual wallet address in retrieval in responding to queries. This is addressed in: feat(retrievalmarket): support wallet address go-fil-markets#130 and integrated here, so that the retrieval deal is initialized with the miner's actual wallet
  3. Third issue is deserializing the return value for creating the payment channel address -- was not using init.ExecReturn. (Note: this probably also applies to code for multisigs but I did not attempt to address that.)

This gets us all the way through creating the payment channel, however...
Creating vouchers still fails - it appears that the payment channel has ID addresses in the From/To, which means that when you try to sign a voucher, the Wallen signing fails when you use just the ID address. I couldn't immediately figure out how to go from ID Address -> Full address with the statemanager. It's fairly clear how to do the other way but I could not immediately figure out how to go this way.

@magik6k magik6k merged commit 98edeef into testnet/3 Mar 1, 2020
@magik6k magik6k deleted the fix/payment-channel-specs-actors branch March 1, 2020 02:31
Kubuxu pushed a commit that referenced this pull request May 12, 2020
…ecs-actors

Fix issues with payment channels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants