fix ClientRetrieve with CAR exporting & add test coverage #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While retrieving data with
IsCAR
flag enabled, the miner fails with messagesno such file or directory
. I extended theTestDealFlow
test to cover this scenario, so it can be used to reproduce the problem, and check that it's working correctly too.To reproduce the problem, take this PR branch, revert the
client.go
change and run the test.Output:
Of course, with the
client.go
fix test pass.The problem is the
os.Open
call, which opens a file in read-only mode when the main intention is writing to a file.cc @hannahhoward