Double Deal Flow #1481
Merged
Double Deal Flow #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
commented
Mar 31, 2020
node/node_test.go
Outdated
Comment on lines
453
to
454
| t.Run("TestDealFlow", func(t *testing.T) { test.TestDealFlow(t, mockSbBuilder, 10*time.Millisecond) }) | ||
| t.Run("TestDoubleDealFlow", func(t *testing.T) { test.TestDoubleDealFlow(t, mockSbBuilder, 10*time.Millisecond) }) |
There was a problem hiding this comment.
- TestDealFlow pass correctly since is the original test
- TestDoubleDealFlow doesn't pass.
api/test/deals.go
Outdated
|
|
||
| r := bytes.NewReader(data) | ||
| fcid, err := client.ClientImportLocal(ctx, r) | ||
| makeDeal(t, ctx, 6, client, miner) |
There was a problem hiding this comment.
So most of the deal making is now on an extracted makeDeal.
This makes TestDealFlow only calling this once, and TestDoubleDealFlow calling it twice... to be sure both are doing the exact same thing (with just randomness changing for the second deal).
|
The issue has been fixed in |
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
|
Rebased now that last commit has |
arajasek
approved these changes
Apr 21, 2020
Kubuxu
pushed a commit
that referenced
this pull request
May 12, 2020
…lowFAIL Double Deal Flow test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a new test for checking the issue #1455.
Test shouldn't pass since this PR adds the test to expose failing.The last rebase include the fix, tests should pass.