Fixes to multisig functionality in CLI #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aagdere
reviewed
Apr 26, 2020
cli/multisig.go
Outdated
| } | ||
|
|
||
| if cctx.Args().Len() > 5 && cctx.Args().Len() != 7 { | ||
| return fmt.Errorf("usage: msig propose <msig addr> <message ID> <proposer address> <desination> <value> [ <method> <params> ]") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("usage: msig propose <msig addr> <message ID> <proposer address> <desination> <value> [ <method> <params> ]") | |
| return fmt.Errorf("usage: msig approve <msig addr> <message ID> <proposer address> <desination> <value> [ <method> <params> ]") |
There was a problem hiding this comment.
Thanks for the catch!
magik6k
approved these changes
Apr 27, 2020
Kubuxu
pushed a commit
that referenced
this pull request
May 12, 2020
Fixes to multisig functionality in CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxnIDParams, which is not an optional paramWith these changes the multisig workflow works #1084