Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieval Payments #196

Merged
merged 21 commits into from
Sep 17, 2019
Merged

Retrieval Payments #196

merged 21 commits into from
Sep 17, 2019

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 16, 2019

No description provided.

@magik6k magik6k marked this pull request as ready for review September 16, 2019 21:25
cli/client.go Outdated Show resolved Hide resolved
paych/simple.go Outdated Show resolved Hide resolved
paych/simple.go Outdated Show resolved Hide resolved
defer ct.lk.Unlock()

tracking, err := ct.commitDs.Get(key)
if err != datastore.ErrNotFound {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would read cleaner as a switch statement

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for things to clean up, but otherwise looks good

@magik6k magik6k merged commit fc5c455 into master Sep 17, 2019
@magik6k magik6k deleted the feat/retrieval-payments branch September 17, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants