Basic single node UI #208
Merged
Basic single node UI #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ctx := ReqContext(cctx) | ||
|
|
||
| // TODO: Probably tell the user how powerful this token is |
There was a problem hiding this comment.
So the correct approach is probably to not relay on tokens like that, and instead have a more 'two-factor' approach:
- User initializes some transaction
- UI calls node, gets a random challenge string (think UUID), shows that to the user
- User calls
lotus auth approve [uuid]- Lotus shows some transaction details to the user
- If user agrees, the transaction proceeds
$ lotus auth approve 73050e44-17fd-4425-b447-a615cfaf899b
Approving transaction:
From: t3-5ou1i8e1-h850b-id6h5t-... # added '-'s for readability
To: t2-uideuid3-itohb-ue4odi-...
Amount: 12.000 000 001 FIL
Method: multisig.Approve(123)
Gas: 1235
Gas price: 0.000 02
Gas cost: 0.000 024 70 FIL
Approve [y/N]:
There was a problem hiding this comment.
parity solves this by having separate webui just for it, when it wants you to approve something it opens a new tab to it.
|
Need some of this for post integration, feel free to still review (it's mostly js so..) |
nonsense
pushed a commit
that referenced
this pull request
Nov 6, 2020
This PR adds a `TestVector` to the `TestDriver` so that test driver methods that apply messages can be recorded in the test vector. refs #194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to have something like the Parity webui.
This is reusing pond components, so it's a bit uglier, but gives a decent insight into what's going on in the node