implement AddFaults method #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Needs rebase for updated circle config) |
magik6k
approved these changes
Sep 23, 2019
whyrusleeping
force-pushed
the
feat/add-faults
branch
from
69f0eab
to
0419945
Compare
nonsense
added a commit
that referenced
this pull request
Nov 6, 2020
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is pretty uncontroversial spec-wise. Just adding in some fault bitfields.
An optimized merge method will be good once we have it, but i have patience.