Feat/miner filter mpool #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Sep 26, 2019
| continue | ||
| } | ||
|
|
||
| if msg.Message.Nonce > inclNonces[from] { |
There was a problem hiding this comment.
Shouldn't this be reverse? The way it's currently written it's only applying one message per origin per block (checked in pond).
There was a problem hiding this comment.
well, the next message needs to be exactly the next nonce. Youre right that we should also have one that makes sure its not less than, this check should probably be !=.
I'll write a test here to check the logic...
|
(We'll also probably need to do this check in pubsub validator, so it's harder to dos the network) |
|
relevant issue from go-filecoin: filecoin-project/venus#2500 We should fix this before opening things up otherwise our friend Peter will send a few terabytes of nastygram traffic at us :P |
magik6k
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the issue where miners break if they encounter a message that doesnt have enough funds.
I considered making the api just return the properly filtered messages, but opted to implement things without changing the API (do more with less!).