Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devnet Docs #241

Merged
merged 3 commits into from
Sep 27, 2019
Merged

Devnet Docs #241

merged 3 commits into from
Sep 27, 2019

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Sep 27, 2019

Merge after #240, and after deploying new devnet (this one will should be way more stable)

@magik6k magik6k changed the base branch from fix/retry-post to master September 27, 2019 23:00
@magik6k magik6k marked this pull request as ready for review September 27, 2019 23:15

var statePledgeCollateralCmd = &cli.Command{
Name: "pledge-collateral",
Usage: "Get minimum miner pledge collateral",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer that this take a 'power' amount, so this becomes 'pledge collateral for power'. But we can make that change later.

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one non-blocking comment, otherwise let's get this show on the road. DevNet2!

@magik6k magik6k merged commit 0ff36ac into master Sep 27, 2019
@magik6k magik6k deleted the docs/devnet branch September 27, 2019 23:19
nonsense pushed a commit that referenced this pull request Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants