Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: only trace messages for the blocks topic #2731

Merged
merged 3 commits into from
Jul 31, 2020
Merged

pubsub: only trace messages for the blocks topic #2731

merged 3 commits into from
Jul 31, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 31, 2020 •
edited
Loading

As discussed with @whyrusleeping, this changes the tracer behaviour to only trace messages for the blocks topic.
Depends on libp2p/go-libp2p-pubsub#369

@vyzo
Copy link
Contributor Author

vyzo commented Jul 31, 2020

Dependency has been merged upstream; we now depend on go-libp2p-pubsub@master and this is ready.

whyrusleeping
whyrusleeping approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this should make things significantly less noisy. Thanks!

@whyrusleeping whyrusleeping merged commit bd6a805 into master Jul 31, 2020
@vyzo vyzo deleted the pubsub-block-tracing branch August 14, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@magik6k magik6k Awaiting requested review from magik6k

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyzo @whyrusleeping