Fix proposal CID in lotus-miner storage-deals list
#2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update storage-deals list command to output the correct proposal CID. previously we were taking the CID without the client signature, which will not be the same CID
magik6k
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix a bug where the deal CID output in
lotus-miner storage-deals listwas incorrect.Implementation
The deal CID is the CID of the signed deal proposal. Previously, we were taking the CID of just the proposal itself, as opposed to the signed proposal, which, due to the additional bytes is different. We already have the CID for the signed proposal directly in the deal struct so we just use that.