Panic if there's a datastore err when writing state to datastore after chain msg #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the datastore when we've already changed chain state
dirkmc
changed the title
magik6k
reviewed
Aug 6, 2020
There was a problem hiding this comment.
Crashing the node is definitely not the correct answer here. Missing some payment channel info may be expensive, but still much less than having the node crash in the middle of some other very expensive operation (submitting a block, submitting window PoSt barely on time, etc.)
|
Fair enough 👍 I will change to just log and return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we send a create channel or add funds message to chain, we write a record of that message into the datastore, so that if lotus is shutdown or crashes, we can start tracking the message again when lotus comes back up.
Ideally we would have a transactional mechanism in place that would
and then be able to recover from incomplete states by inspecting the datastore and the chain.
Without having this transactional mechanism in place, the correct solution is probably to panic when there's a datastore error, because otherwise the system will be in an "undefined" state.
Resolves #2640 (review)