fix(chainwatch): use height to determine unsynced blocks and fix deadlock in sector deal table #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
placer14
suggested changes
Aug 25, 2020
frrist
force-pushed
the
fix/chainwatch/sync
branch
from
d1e488e
to
3f165cc
Compare
placer14
suggested changes
Aug 27, 2020
| @@ -214,7 +205,7 @@ func (p *Processor) Start(ctx context.Context) { | |||
| if err := p.refreshViews(); err != nil { | |||
| log.Errorw("Failed to refresh views", "error", err) | |||
| } | |||
| log.Infow("Processed Batch", "duration", time.Since(loopStart).String()) | |||
| log.Infow("PROCESSED BATCH COMPLETE", "duration", time.Since(loopStart).String()) | |||
frrist
force-pushed
the
fix/chainwatch/sync
branch
from
291e4e4
to
629b5c2
Compare
frrist
force-pushed
the
fix/chainwatch/sync
branch
from
629b5c2
to
f934ebd
Compare
frrist
changed the title
frrist
changed the title
This table may get multiple updates depending on how many blocks get added into a tipset. Each new block affects the tipset state, but the parent state root will remain the same. This allows the very latest value to be applied.
…wer-reward-metrics feat(chainwatch): Add more complete power and reward metrics
magik6k
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were detecting syncing problems with chainwatch which ended up being caused by race condition. This resolves the race condition and improve the sync alogrithm so last synced block is more determistically determined by height rather than by time.