-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some fsm issues #3350
Fix some fsm issues #3350
Conversation
6364f50
to
7806a98
Compare
aa9fb45
to
489d523
Compare
fbe3e47
to
7fdffc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deal recovery stuff and UX/logging all LGTM. I'm less sure about some of the scheduling changes, but I think it all makes sense (or makes no less sense than the earlier code).
On the whole seems fiiine, I guess it all works.
} | ||
|
||
if height >= proposal.StartEpoch { | ||
// TODO: check if we are in an early enough state (before precommit), try to remove the offending pieces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds awful
This PR grew a bit bigger than I've originally expected, but it's really just a bunch of smallish fixes, so reviewing commit-by-commit should be pretty easy.
Summary of changes:
lotus-miner sectors remove [sid]
now works for sectors in all stateslotus-miner sectors status
(1)