Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve publish/republish logic #3592

Merged
merged 5 commits into from
Sep 7, 2020
Merged

Improve publish/republish logic #3592

merged 5 commits into from
Sep 7, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Sep 6, 2020

On top of #3579 and in conjunction with #3518

Improves the publish/republish logic so that:

  • local messages that are pushed to the mpool are not immediately published if they can't be included in the next 20 blocks
  • we only republish messages if they can be included in the next 20 blocks
  • also reduces the republish batch delay to 100ms (from 200ms)

This will reduce our bandwidth requirements and (most important for spam control) our rate of ignored messages.

Base automatically changed from fix/mpool-basefee-check to master September 7, 2020 07:03
@arajasek arajasek mentioned this pull request Sep 7, 2020
9 tasks
@vyzo vyzo force-pushed the feat/improved-publish-logic branch from 92ae6ca to 4122279 Compare September 7, 2020 17:27
@vyzo
Copy link
Contributor Author

vyzo commented Sep 7, 2020

rebased on master and added docstring.

@vyzo
Copy link
Contributor Author

vyzo commented Sep 7, 2020

tests fail on master too, unrelated to this pr.

@Kubuxu
Copy link
Contributor

Kubuxu commented Sep 7, 2020

unrelated:
retrieval event {"name": "ProviderEventUnsealError", "deal ID": "0", "receiver": "12D3KooWSL9Q91czERNFDbXHi5ruo8xqgN4GLyJpMDowrcDHAbQy", "state": "DealStatusFailing", "message": "draining piece reader: failed to read unsealed piece"}

Kubuxu
Kubuxu previously approved these changes Sep 7, 2020
Copy link
Contributor

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the one comment, SGWM.

@Kubuxu Kubuxu merged commit 3398426 into master Sep 7, 2020
@Kubuxu Kubuxu deleted the feat/improved-publish-logic branch September 7, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants