Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only subscribe to pubsub topics once we are synced #3602

Merged
merged 7 commits into from
Sep 7, 2020
Merged

only subscribe to pubsub topics once we are synced #3602

merged 7 commits into from
Sep 7, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Sep 7, 2020

so that we can properly validate stuff.

magik6k
magik6k reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 comment

node/modules/services.go Outdated Show resolved Hide resolved
schomatis
schomatis previously approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sync part LGTM, have not reviewed the reorg diff. IIUC, this assumes that our sync process can rely on the hello protocol and not on the gossipsub one and still be efficient, this needs to be explicitly stated.

node/modules/services.go Outdated Show resolved Hide resolved
@vyzo
Copy link
Contributor Author

vyzo commented Sep 7, 2020

@schomatis we won't get anything from pubsub until we are synced, our validators are a lot stronger these days and Ignore almost everything when out of sync.

@vyzo
Copy link
Contributor Author

vyzo commented Sep 7, 2020

fixed the tests and rebased on master.

schomatis
schomatis previously approved these changes Sep 7, 2020
View reviewed changes
magik6k
magik6k reviewed Sep 7, 2020
View reviewed changes
node/modules/services.go Outdated Show resolved Hide resolved
@magik6k magik6k merged commit ffbbd96 into master Sep 7, 2020
@magik6k magik6k deleted the feat/delayed-pubsub-join branch September 7, 2020 17:08
@arajasek arajasek mentioned this pull request Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@schomatis schomatis schomatis left review comments

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyzo @magik6k @schomatis