Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use latency as initital estimate for blocksync #3648

Merged
merged 6 commits into from
Sep 8, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Sep 8, 2020

No description provided.

Jakub Sztandera added 2 commits September 8, 2020 08:59
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@Kubuxu Kubuxu requested a review from magik6k September 8, 2020 07:07
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Comment + lint

Comment on lines 46 to 49
var newPeer interface{}
ok := true
for ok {
newPeer, ok = <-sub.Out()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just:

Suggested change
var newPeer interface{}
ok := true
for ok {
newPeer, ok = <-sub.Out()
for newPeer := range sub.Out() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I forgot about range chan

Jakub Sztandera added 3 commits September 8, 2020 12:11
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
@magik6k magik6k merged commit 867469e into master Sep 8, 2020
@magik6k magik6k deleted the fix/dont-use-latency branch September 8, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants