Update to specs-actors v0.9.8 #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Sep 10, 2020
chain/gen/genesis/genesis.go
Outdated
| nwv := func(context.Context, abi.ChainEpoch) runtime.NetworkVersion { | ||
| return runtime.NetworkVersion1 | ||
| nwv := func(context.Context, abi.ChainEpoch) network.Version { | ||
| return network.Version1 |
There was a problem hiding this comment.
Not Version2?
Also, I feel like this belongs in build/, NewNetworkVersion or something like that
There was a problem hiding this comment.
Yeeee, fixed (and also in genesis miners setup)
magik6k
reviewed
Sep 10, 2020
chain/stmgr/stmgr.go
Outdated
| @@ -1124,14 +1124,14 @@ func (sm *StateManager) GetCirculatingSupply(ctx context.Context, height abi.Cha | |||
| return csi.FilCirculating, nil | |||
| } | |||
|
|
|||
| func (sm *StateManager) GetNtwkVersion(ctx context.Context, height abi.ChainEpoch) runtime.NetworkVersion { | |||
| func (sm *StateManager) GetNtwkVersion(ctx context.Context, height abi.ChainEpoch) network.Version { | |||
| if build.UpgradeBreezeHeight == 0 { | |||
There was a problem hiding this comment.
It may be hardcoded at -1 now for devnets
arajasek
force-pushed
the
asr/specs-update-0.9.8
branch
from
dd5cb41
to
b00cd87
Compare
|
Merging so we can cut an RC, but post-merge review still welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually fully backwards-compatible with v0.9.7, so we could just merge into master, but might as well send it into the staging branch.