Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont recompute PoST on revert #3833

Closed
wants to merge 5 commits into from
Closed

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Sep 14, 2020

Fixes #3560

Depends on #3689

@dirkmc dirkmc marked this pull request as draft September 14, 2020 13:59
@dirkmc dirkmc changed the base branch from feat/batch-window-PoST to master September 14, 2020 14:00
@dirkmc dirkmc changed the base branch from master to feat/batch-window-PoST September 14, 2020 14:01
@dirkmc dirkmc force-pushed the feat/dont-recompute-PoST branch 2 times, most recently from 8e2e54f to 5840564 Compare September 14, 2020 14:11
@dirkmc
Copy link
Contributor Author

dirkmc commented Sep 14, 2020

@Stebalien @magik6k there are still a few things to be filled in here, and I need to write tests. But I wanted to get your feedback on the state machine approach

@dirkmc dirkmc force-pushed the feat/batch-window-PoST branch 2 times, most recently from 86ec8eb to db998e9 Compare September 15, 2020 07:53
Base automatically changed from feat/batch-window-PoST to master September 15, 2020 08:17
@dirkmc dirkmc force-pushed the feat/dont-recompute-PoST branch 16 times, most recently from 08a1d37 to b2b8bb2 Compare September 17, 2020 13:42
@dirkmc dirkmc marked this pull request as ready for review September 17, 2020 13:42
@dirkmc dirkmc force-pushed the feat/dont-recompute-PoST branch 2 times, most recently from 7d43a2d to b31861e Compare September 17, 2020 14:27
@magik6k magik6k closed this Sep 30, 2020
@Kubuxu Kubuxu deleted the feat/dont-recompute-PoST branch November 25, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not re-compute window PoSt on revert
2 participants