Support Network Upgrades: Payment Channel #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build abstraction for paych actor and switch to using it in payment channel manager and state predicates
hannahhoward
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
dirkmc
reviewed
Sep 16, 2020
There was a problem hiding this comment.
Some nice simplifications in the code and in the tests, great work Hannah 👍
Just one question about ForEachLaneState that @Stebalien may be best placed to answer
| } | ||
|
|
||
| // Iterate lane states | ||
| func (ms *mockState) ForEachLaneState(cb func(idx uint64, dl paych.LaneState) error) error { |
There was a problem hiding this comment.
@Stebalien does amt.ForEach break out of the loop when there's an error? Or does it continue anyway, but save the last error like the implementation of ForEachLaneState here?
There was a problem hiding this comment.
Comment on lines
-529
to
+539
| if !ok { | ||
| ls = &paych.LaneState{ | ||
| Redeemed: types.NewInt(0), | ||
| Nonce: 0, | ||
| } | ||
| laneStates[v.Voucher.Lane] = ls | ||
| } | ||
|
|
||
| if v.Voucher.Nonce < ls.Nonce { | ||
| if ok && v.Voucher.Nonce < ls.Nonce() { | ||
| continue | ||
| } | ||
|
|
||
| ls.Nonce = v.Voucher.Nonce | ||
| ls.Redeemed = v.Voucher.Amount | ||
| laneStates[v.Voucher.Lane] = laneState{v.Voucher.Amount, v.Voucher.Nonce} |
magik6k
approved these changes
Sep 16, 2020
| @@ -226,7 +221,7 @@ func (pm *Manager) GetChannelInfo(addr address.Address) (*ChannelInfo, error) { | |||
| return ca.getChannelInfo(addr) | |||
| } | |||
|
|
|||
| func (pm *Manager) CreateVoucher(ctx context.Context, ch address.Address, voucher paych.SignedVoucher) (*api.VoucherCreateResult, error) { | |||
| func (pm *Manager) CreateVoucher(ctx context.Context, ch address.Address, voucher v0paych.SignedVoucher) (*api.VoucherCreateResult, error) { | |||
There was a problem hiding this comment.
TODO: figure out what to do with the SignedVoucher type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Support actor upgrades -- specifically the payment channels
This covers only the state access part -- I did not attempt to address message submission cause it's not yet addressed in the larger PR. Of particular concern to pay attention to is the use of SignedVoucher -- a fairly complex data structure which is not stored on chain but appears in message submission for the payment channel state, and is tracked off chain in the payment channel manager. The number of references in the code to this data structure is large
Implementation