Add a StateDecodeParams method #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
magik6k
reviewed
Sep 30, 2020
chain/vm/invoker.go
Outdated
|
|
||
| // TODO: ActorUpgrade: Support versioning | ||
| // TODO: Doesn't work well for methods that have params as params (Init's Exec, multisig Propose, etc.) | ||
| func DumpParams(code cid.Cid, method abi.MethodNum, b []byte) (interface{}, error) { |
There was a problem hiding this comment.
node/impl/full/state.go
Outdated
| @@ -422,6 +422,29 @@ func (a *StateAPI) StateReadState(ctx context.Context, actor address.Address, ts | |||
| }, nil | |||
| } | |||
|
|
|||
| func (a *StateAPI) StateDecodeParams(ctx context.Context, msgCid cid.Cid, tsk types.TipSetKey) (interface{}, error) { | |||
There was a problem hiding this comment.
Maybe we should just have this take a target actor, method ID and params bytes? That makes this quite a bit more flexible
arajasek
force-pushed
the
asr/decode-params
branch
from
c308c98
to
ef5d0ff
Compare
arajasek
force-pushed
the
asr/decode-params
branch
from
ef5d0ff
to
5ff4250
Compare
magik6k
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.