Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to set BlockProfileRate and MutexProfileFraction #4140

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Oct 2, 2020

No description provided.

Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to put this behind auth / make opt-in with an env var (this is exposed on the API port)

@Kubuxu
Copy link
Contributor Author

Kubuxu commented Oct 2, 2020

It is behind POST request so the browser has no access to it.

@magik6k
Copy link
Contributor

magik6k commented Oct 2, 2020

Sure, but other internet things do

@whyrusleeping
Copy link
Member

I think its probably fine to say if youre exposing a lotus api publically, you should probably not expose a lotus api publically.

@magik6k magik6k merged commit 2d9123a into master Nov 20, 2020
@magik6k magik6k deleted the feat/mutex-fraction branch November 20, 2020 13:22
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Jan 7, 2021
…utex-fraction

Add options to set BlockProfileRate and MutexProfileFraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants