Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject explicit "calls" at the upgrade height #4231

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Conversation

Stebalien
Copy link
Member

Upgrades can be slow.

  1. If a nil/empty tipset, use the latest non-fork tipset.
  2. If passed an explicit tipset, return an error if it would invoke a fork.
  3. When estimating gas, retry on previous tipsets till we find a non-fork tipset.

@@ -33,11 +33,19 @@ import (
"github.com/filecoin-project/lotus/chain/vm"
)

type UpgradeFunc func(context.Context, *StateManager, ExecCallback, cid.Cid, *types.TipSet) (cid.Cid, error)
// UpgradeFunc is a migration function run ate very upgrade.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling

@Stebalien Stebalien merged commit 413c357 into next Oct 7, 2020
@Stebalien Stebalien deleted the steb/call-at-upgrade branch October 7, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants