Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batch api for push messages #4236

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Oct 8, 2020

Pushing messages one by one causes nonce gap when there are many messages, so add this batch api to solve this problem.

Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can optimize this more later, integrating deeper into mpool to do everything under one lock / assign continous nonces / not send any messages if some checks fail (e.g total balance is not enough)

@magik6k magik6k merged commit 618fed7 into filecoin-project:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants