upgrade specs-actors #4293
Merged
upgrade specs-actors #4293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
anorth
approved these changes
Oct 10, 2020
| } else if !msgs.IsEmpty() { | ||
| // This error is going to be really nasty. | ||
| return cid.Undef, xerrors.Errorf("network upgrade failed: %v", msgs.Messages()) | ||
| } |
There was a problem hiding this comment.
Consider following up with a single-purpose traversal just to accumulate the total token supply and check it's 2bn, but otherwise agree we don't want to invoke these expensive, extensive tests here (which will report some known "errors").
These checks may be _too_ strict and could cause the upgrade to fail unnecessarily.
Stebalien
force-pushed
the
steb/actors-fixes
branch
from
b2db6b0
to
10d464a
Compare
magik6k
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.