Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lotus bench error #4305

Merged
merged 12 commits into from
Nov 20, 2020
Merged

Fix lotus bench error #4305

merged 12 commits into from
Nov 20, 2020

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Oct 11, 2020

fix #4304

@zgfzgf
Copy link
Contributor Author

zgfzgf commented Oct 11, 2020

Hi @magik6k
Why does test fail to modify cmd/lotus-bench/main.go?
Coupling?

ci/circleci: test-short — Your tests failed on CircleCI

@zgfzgf
Copy link
Contributor Author

zgfzgf commented Oct 11, 2020

local:

go test -v -run TestAPIDealFlow node/node_test.go
2020-10-11T17:31:51.017+0800 INFO pubsub go-libp2p-pubsub@v0.3.6/pubsub.go:619 pubsub processloop shutting down
PASS
ok command-line-arguments 410.284s

magik6k
magik6k reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Changes generally look good, just 1 comment

cmd/lotus-bench/main.go
fmt.Printf("seal: commit phase 1: %s (%s)\n", bo.SealingResults[0].Commit1, bps(bo.SectorSize, bo.SealingResults[0].Commit1))
fmt.Printf("seal: commit phase 2: %s (%s)\n", bo.SealingResults[0].Commit2, bps(bo.SectorSize, bo.SealingResults[0].Commit2))
fmt.Printf("seal: verify: %s\n", bo.SealingResults[0].Verify)
fmt.Printf("seal: addPiece: %s (%s)\n", bo.SealingSum.AddPiece, bps(bo.SectorSize, bo.SectorNumber, bo.SealingSum.AddPiece))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to print the average / slowest time here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old code it's the first average

@zgfzgf
Copy link
Contributor Author

zgfzgf commented Nov 3, 2020

hi @magik6k
This is a separate module and will not affect other programs
Early merger

magik6k
magik6k reviewed Nov 20, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflicts :/

@zgfzgf
Copy link
Contributor Author

zgfzgf commented Nov 20, 2020

@magik6k test ok
please merge

magik6k
magik6k approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@magik6k magik6k merged commit 375b7a1 into filecoin-project:master Nov 20, 2020
@zgfzgf zgfzgf deleted the fix-lotus-bench branch December 4, 2020 03:36
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Jan 7, 2021
@magik6k @bibibong
Merge pull request filecoin-project#4305 from zgfzgf/fix-lotus-bench
b8f166b 
Fix lotus bench error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lotus-bench error!!!
2 participants
@zgfzgf @magik6k