add support for early terminate secotrs manually #4433
Conversation
ozhtdong
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
Kubuxu
changed the title
There was a problem hiding this comment.
The current way to call it is;
lotus-miner proving terminate --sectors="437" --really-do-it 1
The current other sector edit commands are as follows:
lotus-miner sectors remove --really-do-it 437
I think you might want to move the command to the sectors endpoint instead of proving, and replace the sectors input. This would also be the only command that allows multiple sectors to be given in a , seperated way - so I'd either remove that option, or add it to all other.
Then there's also the required --sectors flag - whereas in other we can just use --really-do-it
Also, --really-do-it shouldn't be visible in the API output, but only visible through source code (enforcing people to know a bit of programming before they use it ;) )
I also heard that it might be better to put this entire step into the FSM as well (just like the other states).
Last but not least - Thank you! Trying to terminate 1 broken sector early now :)
| }, | ||
| &cli.StringFlag{ | ||
| Name: "sectors", | ||
| Usage: "specied sectors[xx,xx,xx]", |
|
Functionally verified in 1.0.0; |
…hed: - Moving the cmd to lotus-shed so that miners can use this right away without waiting for fsm changes.- Note: this should only be used when the miner is 100% sure that they want to terminate the sector on chain and they will be lose the power and pay a big one-time termination penalty for the sectors. - Only live sectors can be terminated. - To use, run `./lotus-shed sectors terminate --really-do-it=true sectorNum1 sectorNum2`. - A message will be sent and after the message is landed on chain, miner can run `lotus-miner sectors status --on-chain-info <terminated sector number>`, and check Expiration Info at the bottom. Both `OnTime` and `Early` are 0 indicates the sector is terminated.
|
Superseded by #4507 (guessing this can be closed) |
|
@ozhtdong Thank your for the PR first of all. Just want to let you know that we moved your implementation to lotus-shed with some ui changes(to make things more consistent with |
|
@RobQuistNL all right, I agree with those and thank you for your modify, you can close this pr. |
…hed: - Moving the cmd to lotus-shed so that miners can use this right away without waiting for fsm changes.- Note: this should only be used when the miner is 100% sure that they want to terminate the sector on chain and they will be lose the power and pay a big one-time termination penalty for the sectors. - Only live sectors can be terminated. - To use, run `./lotus-shed sectors terminate --really-do-it=true sectorNum1 sectorNum2`. - A message will be sent and after the message is landed on chain, miner can run `lotus-miner sectors status --on-chain-info <terminated sector number>`, and check Expiration Info at the bottom. Both `OnTime` and `Early` are 0 indicates the sector is terminated.
No description provided.