Expose ClientDealSize via CLI #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
reviewed
Oct 26, 2020
cli/client.go
Outdated
| return err | ||
| } | ||
|
|
||
| fmt.Printf("Deal sizes for data cid %s\n", ellipsis(dataCid.String(), 8)) |
There was a problem hiding this comment.
I don't think we need this, the user has just provided this as a parameter
Suggested change
| fmt.Printf("Deal sizes for data cid %s\n", ellipsis(dataCid.String(), 8)) |
cli/client.go
Outdated
| } | ||
|
|
||
| fmt.Printf("Deal sizes for data cid %s\n", ellipsis(dataCid.String(), 8)) | ||
| fmt.Printf(" Piece Size: %v\n", ds.PieceSize) |
There was a problem hiding this comment.
Suggested change
| fmt.Printf(" Piece Size: %v\n", ds.PieceSize) | |
| fmt.Printf("Piece Size: %v\n", ds.PieceSize) |
cli/client.go
Outdated
| @@ -1698,6 +1699,40 @@ var clientRestartTransfer = &cli.Command{ | |||
| }, | |||
| } | |||
|
|
|||
| var clientDealSize = &cli.Command{ | |||
| Name: "deal-size", | |||
There was a problem hiding this comment.
I'd call this stat in case we want to add other things here like CommP
ingar
force-pushed
the
feat/client-deal-size-cli
branch
from
21f5a2e
to
8141f7b
Compare
magik6k
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While
ClientDealSizeis exposed via the JSON API, there are some users using the CLI that need this information to create deals (without using interactive deal creation).Example output