Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvx extract: make it work with secp messages. #4583

Merged
merged 2 commits into from
Nov 20, 2020
Merged

tvx extract: make it work with secp messages. #4583

merged 2 commits into from
Nov 20, 2020

Commits on Oct 24, 2020

  1. tvx extract: make it work with secp messages. 

    Unfortunately ChainGetMessage returns a *types.Message, which in
the case of secp messages is lacking the signature. The signature
is part of the input to calculate the CID on secp messages. Therefore,
calling `.Cid()` on the result of ChainGetMessage for this kind of
message will lead to an incorrect CID.

tvx was relying on that call to return the correct CID. Since this is
not the case (and this is a footgun that needs to be corrected, ideally
together with the *types.{,Signed}Message duality mess), I'm replacing
the comparison.
    @raulk
    raulk committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    cdfa869 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. finish comment.

    @raulk
    raulk committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    bb9d2b5 View commit details
    Browse the repository at this point in the history