refactor: share code between CLI tests #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
dirkmc
force-pushed
the
refactor/paych-cli-test
branch
from
12a7ed2
to
073478f
Compare
dirkmc
force-pushed
the
refactor/paych-cli-test
branch
from
073478f
to
b097a5f
Compare
magik6k
reviewed
Oct 26, 2020
cli/test/mockcli.go
Outdated
| func (c *mockCLIClient) runCmd(input []string) string { | ||
| cmd := c.cmdByNameSub(input[0], input[1]) | ||
| out, err := c.runCmdRaw(cmd, input[2:]) | ||
| func (c *MockCLIClient) RunCmd(input []string) string { |
There was a problem hiding this comment.
Could be
Suggested change
| func (c *MockCLIClient) RunCmd(input []string) string { | |
| func (c *MockCLIClient) RunCmd(input ...string) string { |
So we could avoid constructing those cmd = []string{..} arrays everywhere
magik6k
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just takes care of some tech-debt, no changes to non-test code.
This PR removes some duplicate code from the payment channels CLI tests.