Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagefsm: Fix GetTicket loop when the sector is already precommitted #4643

Merged
merged 1 commit into from
Oct 29, 2020
Merged

storagefsm: Fix GetTicket loop when the sector is already precommitted #4643

merged 1 commit into from
Oct 29, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Oct 29, 2020

When we recompute PC1 after it has been precommitted, we'd fall into a loop between GetTicket and PreCommit1 states:

...
7992.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"JgPZnq+lJqH/mw640Jw9xRn2IeL9ZT59/fZsreFjddI=","TicketEpoch":182408}}
7993.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorOldTicket]	{"User":{}}
7994.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"JgPZnq+lJqH/mw640Jw9xRn2IeL9ZT59/fZsreFjddI=","TicketEpoch":182408}}
7995.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorOldTicket]	{"User":{}}
7996.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"JgPZnq+lJqH/mw640Jw9xRn2IeL9ZT59/fZsreFjddI=","TicketEpoch":182408}}
7997.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorOldTicket]	{"User":{}}
7998.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"JgPZnq+lJqH/mw640Jw9xRn2IeL9ZT59/fZsreFjddI=","TicketEpoch":182408}}
7999.	2020-10-29 09:42:16 +0100 CET:	[event;sealing.SectorOldTicket]	{"User":{}}
8000.	2020-10-29 09:49:17 +0100 CET:	[event;sealing.SectorTicket]	{"User":{"TicketValue":"JgPZnq+lJqH/mw640Jw9xRn2IeL9ZT59/fZsreFjddI=","TicketEpoch":182408}}

@magik6k magik6k merged commit ee814fb into master Oct 29, 2020
@magik6k magik6k deleted the fix/fsm-ticket-loop branch October 29, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees
No one assigned
Labels
kind/bug Kind: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magik6k @whyrusleeping