Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: add msig pendingtxn diffing and comp #4719

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

frrist
Copy link
Member

@frrist frrist commented Nov 4, 2020

add diffing logic for multisig actors pending transcription HAMT

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but I'm not sure how useful the diff itself will be in practice. It won't tell you if a transaction has been approved or was canceled.

@frrist
Copy link
Member Author

frrist commented Nov 4, 2020

This works but I'm not sure how useful the diff itself will be in practice. It won't tell you if a transaction has been approved or was canceled.

True. The motivation here is to allow Visor to track changes in the multisigs pending transaction HAMT.

One way to obtain the result of these transactions is by inspecting the return value of Propose, Approve, and Cancel messages sent to a multisig actor.

@magik6k magik6k merged commit 6bb8521 into master Nov 6, 2020
@magik6k magik6k deleted the frrist/msig-diffing branch November 6, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants