Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dont crash on startup if funds migration fails #4827

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 12, 2020

Don't crash on startup if funds migration fails.

I'm not 100% sure this is what we want to do. It may cause some in-progress deals to fail, but is probably better than crashing.

Edit: The correct solution here is probably for the migration to subtract the amount of completed / failed deals from the reserved amount

@jsign
Copy link
Contributor

jsign commented Nov 12, 2020

I can confirm it fixes #4823

@dirkmc dirkmc marked this pull request as draft November 12, 2020 17:17
@hannahhoward hannahhoward marked this pull request as ready for review November 12, 2020 17:55
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I think this is the best fix we have, for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants