Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .sec scale to measurements; humanize for metric tags #4989

Merged
merged 1 commit into from
Nov 24, 2020
Merged

add .sec scale to measurements; humanize for metric tags #4989

merged 1 commit into from
Nov 24, 2020

Conversation

nonsense
Copy link
Member

This PR is updating the graphsync testplan:

  1. It adds .sec to the tag name, which is used as a unit for the y-axis when we visualise stats.
  2. It humanizes the tags / params for the test, so that they are more meaningful when visualising stats.

@nonsense nonsense marked this pull request as ready for review November 24, 2020 18:12
@magik6k magik6k merged commit 2507031 into master Nov 24, 2020
@magik6k magik6k deleted the graphsync-scale-measurements branch November 24, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonsense @magik6k