Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sector check command #5041

Merged
merged 4 commits into from
Dec 1, 2020
Merged

Sector check command #5041

merged 4 commits into from
Dec 1, 2020

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Nov 27, 2020

No description provided.

@magik6k
Copy link
Contributor Author

magik6k commented Nov 27, 2020

(fixed up #5013)

@magik6k magik6k mentioned this pull request Nov 27, 2020
Closed
magik6k
magik6k commented Nov 30, 2020
View reviewed changes
Copy link
Contributor Author

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my changes (which should get another review)

@magik6k
Copy link
Contributor Author

magik6k commented Nov 30, 2020

(tested on my miner)

dirkmc
dirkmc approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM 👍

storage/wdpost_run_test.go Outdated Show resolved Hide resolved
vyzo
vyzo approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magik6k @dirkmc
wdpost: Update comment
054327b 
Co-authored-by: dirkmc <dirkmdev@gmail.com>
@magik6k magik6k merged commit 614f45d into master Dec 1, 2020
@magik6k magik6k deleted the feat/5013 branch December 1, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

@dirkmc dirkmc dirkmc approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magik6k @vyzo @dirkmc @Kubuxu @s1m0n21