Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shed bitfield: Cleanup, add merge command #5047

Merged
merged 8 commits into from
Jan 30, 2021

Conversation

zgfzgf
Copy link
Contributor

@zgfzgf zgfzgf commented Nov 28, 2020

optimize code
use func
add merge

Comment on lines -113 to -119
Flags: []cli.Flag{
&cli.StringFlag{
Name: "enc",
Value: "base64",
Usage: "specify input encoding to parse",
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this flag is needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and in other places)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super are already enc
use func Unified use of the upper level enc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  Name:        "bitfield",
    Usage:       "Bitfield analyze tool",
    Description: "analyze bitfields",
    Flags: []cli.Flag{
            &cli.StringFlag{
                    Name:  "enc",
                    Value: "base64",
                    Usage: "specify input encoding to parse",
            },
    },

@magik6k magik6k changed the title Feat shed bitfield shed bitfield: Cleanup, add merge command Jan 30, 2021
Copy link
Contributor

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicer, thanks!

@magik6k magik6k merged commit fed3e82 into filecoin-project:master Jan 30, 2021
bibibong pushed a commit to EpiK-Protocol/go-epik that referenced this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants