Error out deals that are not activated by proposed deal start epoch #5061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
requested review from
Kubuxu,
magik6k and
whyrusleeping
as code owners
dirkmc
force-pushed
the
fix/err-late-deals
branch
from
ffda847
to
37eb405
Compare
dirkmc
force-pushed
the
fix/err-late-deals
branch
from
37eb405
to
e02a366
Compare
hannahhoward
approved these changes
Nov 30, 2020
dirkmc
force-pushed
the
fix/err-late-deals
branch
from
67f9b58
to
6bbb8ec
Compare
dirkmc
force-pushed
the
fix/err-late-deals
branch
from
0d6eb2d
to
cb044f8
Compare
Co-authored-by: Łukasz Magiera <magik6k@users.noreply.github.com>
magik6k
approved these changes
Dec 1, 2020
|
Is it a better practice to specify a startepoch much later to allow more time to seal? |
|
It depends on the individual miner. If the miner is already overloaded and struggling to seal in time, setting the proposed deal start epoch to a later time may not help much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4990
When a deal is terminated by the miner, the client can get stuck in
StorageDealSealing.This PR adds functionality to the functions that wait for pre-commit and prove-commit such that they will callback with an error if the chain reaches the proposed start epoch for the deal without the deal being activated.
Fixes #4977
Provides a better error message for when the deal is not found.
Old: "deal 12345 not found"
New: "deal 12345 not found - deal may not have completed sealing before deal proposal start epoch, or deal may have been slashed"